goodhistogram: gofmt benchmark_test.go#6
Merged
Conversation
Bring the prometheus.HistogramOpts struct literal into gofmt alignment — NativeHistogramMaxBucketNumber is the longest key, so the surrounding fields need an extra space before their values for the colons to line up. Caught while reviewing PR #5; pre-existing on main, fixing separately to keep that PR's diff focused. Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
5 tasks
kyle-a-wong
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prometheus.HistogramOptsstruct literal inbenchmark_test.gointogofmtalignment.NativeHistogramMaxBucketNumberis the longest key in the struct, so the surrounding fields need an extra space before their values for the colons to line up.Caught while reviewing #5; the issue is pre-existing on
mainand unrelated to that PR's changes, so fixing it separately keeps #5's diff focused on the actual feature.Test plan
gofmt -l .is now cleango build ./...go test ./...